From 13f4d639fda16be1a2d43bd2629b77ce1042da19 Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Tue, 12 Nov 2019 19:51:33 +0000 Subject: [PATCH] gtkstyleprovider: Rename -gtk-style-changed signal to have a valid name MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signal names must start with a letter. They can’t start with a hyphen. It was originally added in commit 74f4c6f6bd755967 with no given reason for why the signal name was chosen as it was. Signed-off-by: Philip Withnall --- gtk/gtkstylecascade.c | 4 ++-- gtk/gtkstylecontext.c | 2 +- gtk/gtkstyleprovider.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gtk/gtkstylecascade.c b/gtk/gtkstylecascade.c index 4c94696742..d0010de2be 100644 --- a/gtk/gtkstylecascade.c +++ b/gtk/gtkstylecascade.c @@ -294,7 +294,7 @@ _gtk_style_cascade_set_parent (GtkStyleCascade *cascade, { g_object_ref (parent); g_signal_connect_swapped (parent, - "-gtk-private-changed", + "gtk-private-changed", G_CALLBACK (gtk_style_provider_changed), cascade); } @@ -325,7 +325,7 @@ _gtk_style_cascade_add_provider (GtkStyleCascade *cascade, data.provider = g_object_ref (provider); data.priority = priority; data.changed_signal_id = g_signal_connect_swapped (provider, - "-gtk-private-changed", + "gtk-private-changed", G_CALLBACK (gtk_style_provider_changed), cascade); diff --git a/gtk/gtkstylecontext.c b/gtk/gtkstylecontext.c index 7ba0c3f61d..2072dd8a3b 100644 --- a/gtk/gtkstylecontext.c +++ b/gtk/gtkstylecontext.c @@ -265,7 +265,7 @@ gtk_style_context_set_cascade (GtkStyleContext *context, { g_object_ref (cascade); priv->cascade_changed_id = g_signal_connect (cascade, - "-gtk-private-changed", + "gtk-private-changed", G_CALLBACK (gtk_style_context_cascade_changed), context); } diff --git a/gtk/gtkstyleprovider.c b/gtk/gtkstyleprovider.c index b9c19cd206..c454f19c1e 100644 --- a/gtk/gtkstyleprovider.c +++ b/gtk/gtkstyleprovider.c @@ -45,7 +45,7 @@ static guint signals[LAST_SIGNAL]; static void gtk_style_provider_default_init (GtkStyleProviderInterface *iface) { - signals[CHANGED] = g_signal_new (I_("-gtk-private-changed"), + signals[CHANGED] = g_signal_new (I_("gtk-private-changed"), G_TYPE_FROM_INTERFACE (iface), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GtkStyleProviderInterface, changed), -- 2.30.2